From: Jamie <101677823+ordinary-jamie@users.noreply.github.com>
Date: Wed, 13 Dec 2023 01:26:40 +0000 (+1100)
Subject: gh-112622: Pass name to loop create_task method (#112623)
X-Git-Tag: v3.13.0a3~409
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=a3a1cb48456c809f7b1ab6a6ffe83e8b3f69be0f;p=thirdparty%2FPython%2Fcpython.git

gh-112622: Pass name to loop create_task method (#112623)

This affects task creation through either `asyncio.create_task()` or `TaskGroup.create_task()` -- the redundant call to `task.set_name()` is skipped. We still call `set_name()` when a task factory is involved, because the task factory call signature (unfortunately) doesn't take a `name` argument.
---

diff --git a/Lib/asyncio/taskgroups.py b/Lib/asyncio/taskgroups.py
index 91be0decc41c..cb9c1ce4d7d1 100644
--- a/Lib/asyncio/taskgroups.py
+++ b/Lib/asyncio/taskgroups.py
@@ -158,10 +158,10 @@ class TaskGroup:
         if self._aborting:
             raise RuntimeError(f"TaskGroup {self!r} is shutting down")
         if context is None:
-            task = self._loop.create_task(coro)
+            task = self._loop.create_task(coro, name=name)
         else:
-            task = self._loop.create_task(coro, context=context)
-        task.set_name(name)
+            task = self._loop.create_task(coro, name=name, context=context)
+
         # optimization: Immediately call the done callback if the task is
         # already done (e.g. if the coro was able to complete eagerly),
         # and skip scheduling a done callback
diff --git a/Lib/asyncio/tasks.py b/Lib/asyncio/tasks.py
index e84b21390557..fafee3e738f6 100644
--- a/Lib/asyncio/tasks.py
+++ b/Lib/asyncio/tasks.py
@@ -404,11 +404,10 @@ def create_task(coro, *, name=None, context=None):
     loop = events.get_running_loop()
     if context is None:
         # Use legacy API if context is not needed
-        task = loop.create_task(coro)
+        task = loop.create_task(coro, name=name)
     else:
-        task = loop.create_task(coro, context=context)
+        task = loop.create_task(coro, name=name, context=context)
 
-    task.set_name(name)
     return task
 
 
diff --git a/Misc/NEWS.d/next/Library/2023-12-03-01-01-52.gh-issue-112622.1Z8cpx.rst b/Misc/NEWS.d/next/Library/2023-12-03-01-01-52.gh-issue-112622.1Z8cpx.rst
new file mode 100644
index 000000000000..91c88bac334d
--- /dev/null
+++ b/Misc/NEWS.d/next/Library/2023-12-03-01-01-52.gh-issue-112622.1Z8cpx.rst
@@ -0,0 +1,2 @@
+Ensure ``name`` parameter is passed to event loop in
+:func:`asyncio.create_task`.