From: Volker Lendecke <vl@samba.org>
Date: Fri, 8 Jun 2012 12:29:41 +0000 (+0200)
Subject: s3: Assigning ?True:False to a bool is a bit pointless
X-Git-Tag: samba-4.0.0beta2~272
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=a3b4a5d7793b208436e541f2382c96c35fa31089;p=thirdparty%2Fsamba.git

s3: Assigning ?True:False to a bool is a bit pointless

Signed-off-by: Michael Adam <obnox@samba.org>
---

diff --git a/source3/smbd/open.c b/source3/smbd/open.c
index a098124618b..d5fba4db192 100644
--- a/source3/smbd/open.c
+++ b/source3/smbd/open.c
@@ -776,12 +776,11 @@ static NTSTATUS open_file(files_struct *fsp,
 	fsp->vuid = req ? req->vuid : UID_FIELD_INVALID;
 	fsp->file_pid = req ? req->smbpid : 0;
 	fsp->can_lock = True;
-	fsp->can_read = (access_mask & FILE_READ_DATA) ? True : False;
+	fsp->can_read = ((access_mask & FILE_READ_DATA) != 0);
 	if (!CAN_WRITE(conn)) {
 		fsp->can_write = False;
 	} else {
-		fsp->can_write = (access_mask & (FILE_WRITE_DATA | FILE_APPEND_DATA)) ?
-			True : False;
+		fsp->can_write = ((access_mask & (FILE_WRITE_DATA | FILE_APPEND_DATA)) != 0);
 	}
 	fsp->print_file = NULL;
 	fsp->modified = False;