From: Roger Dingledine <arma@torproject.org>
Date: Wed, 18 Aug 2004 09:49:17 +0000 (+0000)
Subject: stop taking strlen of an uninitialized buffer
X-Git-Tag: tor-0.0.8rc1~13
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=a447570036453ee2a5e3a3fda263aaf754b73021;p=thirdparty%2Ftor.git

stop taking strlen of an uninitialized buffer
we were (are?) printing garbage in the rephist stats


svn:r2284
---

diff --git a/src/or/rephist.c b/src/or/rephist.c
index c94b19fa15..603077ce5d 100644
--- a/src/or/rephist.c
+++ b/src/or/rephist.c
@@ -266,9 +266,10 @@ void rep_hist_dump_stats(time_t now, int severity)
         or_history->n_conn_ok, or_history->n_conn_fail+or_history->n_conn_ok,
         upt, upt+downt, uptime*100.0);
 
-    if (!strmap_isempty(or_history->link_history_map)) {
+    if (!strmap_isempty(or_history->link_history_map))
       strcpy(buffer, "    Good extend attempts: ");
-    }
+    else
+      *buffer = '\0';
     len = strlen(buffer);
     for (lhist_it = strmap_iter_init(or_history->link_history_map);
          !strmap_iter_done(lhist_it);