From: Yu Watanabe <watanabe.yu+github@gmail.com>
Date: Mon, 28 Feb 2022 02:15:01 +0000 (+0900)
Subject: network: refuse to configure link properties when in initialized state
X-Git-Tag: v251-rc1~164^2~3
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=a48ffe47cf1db98694d2013bf97f62f55e4c3d27;p=thirdparty%2Fsystemd.git

network: refuse to configure link properties when in initialized state

The condition should be satisfied only when users request to reconfigure
the link, and in that case, all request will be cancelled. Hence, it is
not necessary to process the request.
---

diff --git a/src/network/networkd-setlink.c b/src/network/networkd-setlink.c
index a3b52dc8d24..47dc6720ac0 100644
--- a/src/network/networkd-setlink.c
+++ b/src/network/networkd-setlink.c
@@ -486,7 +486,7 @@ static int link_is_ready_to_set_link(Link *link, Request *req) {
 
         op = PTR_TO_INT(req->set_link_operation_ptr);
 
-        if (!IN_SET(link->state, LINK_STATE_INITIALIZED, LINK_STATE_CONFIGURING, LINK_STATE_CONFIGURED))
+        if (!IN_SET(link->state, LINK_STATE_CONFIGURING, LINK_STATE_CONFIGURED))
                 return false;
 
         switch (op) {
@@ -1017,7 +1017,7 @@ static int link_up_or_down(Link *link, bool up, Request *req) {
 static bool link_is_ready_to_activate(Link *link) {
         assert(link);
 
-        if (!IN_SET(link->state, LINK_STATE_INITIALIZED, LINK_STATE_CONFIGURING, LINK_STATE_CONFIGURED))
+        if (!IN_SET(link->state, LINK_STATE_CONFIGURING, LINK_STATE_CONFIGURED))
                 return false;
 
         if (link->set_link_messages > 0)