From: Mike Bayer <mike_mp@zzzcomputing.com>
Date: Sat, 6 Feb 2010 00:01:39 +0000 (+0000)
Subject: - Re-established initial support for pymssql.
X-Git-Tag: rel_0_6beta2~225
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=a4b9cf05ac91ed5c3d7d4ed06f270f7aa82cfdf3;p=thirdparty%2Fsqlalchemy%2Fsqlalchemy.git

- Re-established initial support for pymssql.
---

diff --git a/CHANGES b/CHANGES
index db59e629e7..e3f22b1ab2 100644
--- a/CHANGES
+++ b/CHANGES
@@ -21,6 +21,9 @@ CHANGES
 - sql
   - Added math negation operator support, -x.
 
+- mssql
+  - Re-established initial support for pymssql.
+  
 0.6beta1
 ========
 - Major Release
diff --git a/lib/sqlalchemy/dialects/mssql/pymssql.py b/lib/sqlalchemy/dialects/mssql/pymssql.py
index 0961c2e760..71f583b136 100644
--- a/lib/sqlalchemy/dialects/mssql/pymssql.py
+++ b/lib/sqlalchemy/dialects/mssql/pymssql.py
@@ -1,3 +1,9 @@
+"""
+Support for the pymssql dialect.
+
+Going forward we will be supporting the 1.0 release of pymssql.
+
+"""
 from sqlalchemy.dialects.mssql.base import MSDialect
 from sqlalchemy import types as sqltypes
 
@@ -8,7 +14,7 @@ class MSDialect_pymssql(MSDialect):
     driver = 'pymssql'
 
     @classmethod
-    def import_dbapi(cls):
+    def dbapi(cls):
         import pymssql as module
         # pymmsql doesn't have a Binary method.  we use string
         # TODO: monkeypatching here is less than ideal
@@ -19,17 +25,8 @@ class MSDialect_pymssql(MSDialect):
         super(MSSQLDialect_pymssql, self).__init__(**params)
         self.use_scope_identity = True
 
-        # pymssql understands only ascii
-        if self.convert_unicode:
-            util.warn("pymssql does not support unicode")
-            self.encoding = params.get('encoding', 'ascii')
-
 
     def create_connect_args(self, url):
-        if hasattr(self, 'query_timeout'):
-            # ick, globals ?   we might want to move this....
-            self.dbapi._mssql.set_query_timeout(self.query_timeout)
-
         keys = url.query
         if keys.get('port'):
             # pymssql expects port as host:port, not a separate arg
@@ -40,7 +37,4 @@ class MSDialect_pymssql(MSDialect):
     def is_disconnect(self, e):
         return isinstance(e, self.dbapi.DatabaseError) and "Error 10054" in str(e)
 
-    def do_begin(self, connection):
-        pass
-
 dialect = MSDialect_pymssql
\ No newline at end of file