From: Nick Porter <nick@portercomputing.co.uk>
Date: Wed, 10 Feb 2021 16:44:18 +0000 (+0000)
Subject: Ensure DH parameters are created before stopping dovecot as root (#3927)
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=a4e2b2fc80e702626fb394f56a592001fc5f0743;p=thirdparty%2Ffreeradius-server.git

Ensure DH parameters are created before stopping dovecot as root (#3927)
---

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 4c502b3440b..4a2c29df22f 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -270,10 +270,16 @@ jobs:
         sudo systemctl stop slapd
         sudo aa-complain /usr/sbin/slapd
 
+    # The sleep before stopping dovecot gives it time to produce the DH parameters file.
+    # Test dovecot instances don't run as root so if this file doesn't exist then there
+    # are permissions issues and the SSL instance of dovecot doesn't work
     - name: Install fixture (dovecot imapd)
       if: ${{ matrix.env.TEST_TYPE == 'fixtures' }}
       run: |
         sudo apt-get install -y --no-install-recommends dovecot-imapd
+        while [ ! -f /var/lib/dovecot/ssl-parameters.dat ] ; do
+            sleep 1
+        done
         sudo systemctl stop dovecot
         sudo aa-complain /usr/sbin/dovecot