From: Ameya Palande <2ameya@gmail.com> Date: Thu, 26 Feb 2015 20:05:51 +0000 (-0800) Subject: mfd: kempld-core: Fix callback return value check X-Git-Tag: v3.16.35~2392 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=a58c7438e2e36750088dc53c912e69a99e4b9444;p=thirdparty%2Fkernel%2Fstable.git mfd: kempld-core: Fix callback return value check commit c8648508ebfc597058d2cd00b6c539110264a167 upstream. On success, callback function returns 0. So invert the if condition check so that we can break out of loop. Signed-off-by: Ameya Palande <2ameya@gmail.com> Signed-off-by: Lee Jones Signed-off-by: Luis Henriques --- diff --git a/drivers/mfd/kempld-core.c b/drivers/mfd/kempld-core.c index f7ff0188603de..7112308fa8bec 100644 --- a/drivers/mfd/kempld-core.c +++ b/drivers/mfd/kempld-core.c @@ -738,7 +738,7 @@ static int __init kempld_init(void) if (force_device_id[0]) { for (id = kempld_dmi_table; id->matches[0].slot != DMI_NONE; id++) if (strstr(id->ident, force_device_id)) - if (id->callback && id->callback(id)) + if (id->callback && !id->callback(id)) break; if (id->matches[0].slot == DMI_NONE) return -ENODEV;