From: Benjamin Peterson <benjamin@python.org>
Date: Wed, 1 Apr 2015 15:16:40 +0000 (-0400)
Subject: remove assignment in conditional
X-Git-Tag: v2.7.10rc1~84
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=a5a44aba3f0e21753314ca6cfd766083a22b387f;p=thirdparty%2FPython%2Fcpython.git

remove assignment in conditional
---

diff --git a/Modules/socketmodule.c b/Modules/socketmodule.c
index e9e4479a6678..cbc3223d9894 100644
--- a/Modules/socketmodule.c
+++ b/Modules/socketmodule.c
@@ -4207,7 +4207,8 @@ socket_getaddrinfo(PyObject *self, PyObject *args)
         goto err;
     }
 
-    if ((all = PyList_New(0)) == NULL)
+    all = PyList_New(0);
+    if (all == NULL)
         goto err;
     for (res = res0; res; res = res->ai_next) {
         PyObject *addr =