From: Lennart Poettering <lennart@poettering.net>
Date: Fri, 15 May 2015 19:06:40 +0000 (+0200)
Subject: CODING_STYLE: document best practices when initializing structs
X-Git-Tag: v220~116
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=a5ecb0cec25befafdee1e32c6f24cda8e29f89af;p=thirdparty%2Fsystemd.git

CODING_STYLE: document best practices when initializing structs
---

diff --git a/CODING_STYLE b/CODING_STYLE
index 00986eb43c3..795521cc6a6 100644
--- a/CODING_STYLE
+++ b/CODING_STYLE
@@ -269,3 +269,21 @@
   behaviour in this case, so consider using them as an alternative.)
   Regarding not using alloca() within function parameters, see the
   BUGS section of the alloca(3) man page.
+
+- Use memzero() or even better zero() instead of memset(..., 0, ...)
+
+- Instead of using memzero()/memset() to initialize structs allocated
+  on the stack, please try to use c99 structure initializers. It's
+  short, prettier and actually even faster at execution. Hence:
+
+          struct foobar t = {
+                  .foo = 7,
+                  .bar = "bazz",
+          };
+
+  instead of:
+
+          struct foobar t;
+          zero(t);
+          t.foo = 7;
+          t.bar = "bazz";