From: Mark Michelson <mmichelson@digium.com>
Date: Tue, 24 Mar 2009 22:40:39 +0000 (+0000)
Subject: Merged revisions 184078 via svnmerge from
X-Git-Tag: 11.0.0-beta1~5186
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=a7028f2bc615f10fbbfc0ed3f99c3af3fdf5020f;p=thirdparty%2Fasterisk.git

Merged revisions 184078 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r184078 | mmichelson | 2009-03-24 17:34:45 -0500 (Tue, 24 Mar 2009) | 9 lines

  Change NULL pointer check to be ast_strlen_zero.

  The 'digit' variable is guaranteed to be non-NULL, so the if
  statement could never evaluate true. Changing to ast_strlen_zero
  makes the logic correct.

  This was found while reviewing ast_channel_ao2 code review.
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@184079 65c4cc65-6c06-0410-ace0-fbb531ad65f3
---

diff --git a/apps/app_senddtmf.c b/apps/app_senddtmf.c
index 05faf2221a..9842c412e7 100644
--- a/apps/app_senddtmf.c
+++ b/apps/app_senddtmf.c
@@ -106,7 +106,7 @@ static int manager_play_dtmf(struct mansession *s, const struct message *m)
 		astman_send_error(s, m, "Channel not specified");
 		return 0;
 	}
-	if (!digit) {
+	if (ast_strlen_zero(digit)) {
 		astman_send_error(s, m, "No digit specified");
 		ast_channel_unlock(chan);
 		return 0;