From: Yu Watanabe <watanabe.yu+github@gmail.com>
Date: Fri, 20 Nov 2020 13:58:23 +0000 (+0900)
Subject: link-config: warn when MACAddress= is set with MACAddressPolicy=persistent or random
X-Git-Tag: v247~23^2~1
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=a7a12bf4040cd140376bb12700d3920884bc803c;p=thirdparty%2Fsystemd.git

link-config: warn when MACAddress= is set with MACAddressPolicy=persistent or random
---

diff --git a/src/udev/net/link-config.c b/src/udev/net/link-config.c
index 0519635748c..d12fd0e2991 100644
--- a/src/udev/net/link-config.c
+++ b/src/udev/net/link-config.c
@@ -181,6 +181,13 @@ int link_load_one(link_config_ctx *ctx, const char *filename) {
                 return 0;
         }
 
+        if (IN_SET(link->mac_address_policy, MAC_ADDRESS_POLICY_PERSISTENT, MAC_ADDRESS_POLICY_RANDOM) && link->mac) {
+                log_warning("%s: MACAddress= in [Link] section will be ignored when MACAddressPolicy= "
+                            "is set to \"persistent\" or \"random\".",
+                            filename);
+                link->mac = mfree(link->mac);
+        }
+
         log_debug("Parsed configuration file %s", filename);
 
         LIST_PREPEND(links, ctx->links, TAKE_PTR(link));