From: Berker Peksag <berker.peksag@gmail.com>
Date: Fri, 11 Dec 2015 21:48:13 +0000 (+0200)
Subject: Issue #25755: Move PropertyWritableDoc into the test case
X-Git-Tag: v3.6.0a1~925^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=a7d81270ccb5af4a1c514f267db5295c6d313e15;p=thirdparty%2FPython%2Fcpython.git

Issue #25755: Move PropertyWritableDoc into the test case

This fixes a test failure in refleak mode because
test_property_decorator_doc_writable no longer modifies
the class in module level.

Initial patch by Nan Wu and Torsten Landschoff (from issue 25757)
---

diff --git a/Lib/test/test_property.py b/Lib/test/test_property.py
index 5addd363ed4f..26b7d5283a22 100644
--- a/Lib/test/test_property.py
+++ b/Lib/test/test_property.py
@@ -76,13 +76,6 @@ class PropertyNewGetter(object):
         """new docstring"""
         return 8
 
-class PropertyWritableDoc(object):
-
-    @property
-    def spam(self):
-        """Eggs"""
-        return "eggs"
-
 class PropertyTests(unittest.TestCase):
     def test_property_decorator_baseclass(self):
         # see #1620
@@ -168,6 +161,13 @@ class PropertyTests(unittest.TestCase):
     @unittest.skipIf(sys.flags.optimize >= 2,
                      "Docstrings are omitted with -O2 and above")
     def test_property_decorator_doc_writable(self):
+        class PropertyWritableDoc(object):
+
+            @property
+            def spam(self):
+                """Eggs"""
+                return "eggs"
+
         sub = PropertyWritableDoc()
         self.assertEqual(sub.__class__.spam.__doc__, 'Eggs')
         sub.__class__.spam.__doc__ = 'Spam'