From: Lennart Poettering <lennart@poettering.net>
Date: Tue, 5 Jun 2018 18:47:26 +0000 (+0200)
Subject: core: be a bit stricter when validating SYSTEMD_ALIAS udev props
X-Git-Tag: v239~123^2~2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=a7f8be01aa746eca06cea6970fe83bba99ef4a37;p=thirdparty%2Fsystemd.git

core: be a bit stricter when validating SYSTEMD_ALIAS udev props
---

diff --git a/src/core/device.c b/src/core/device.c
index 06151568207..915991bf90f 100644
--- a/src/core/device.c
+++ b/src/core/device.c
@@ -579,10 +579,12 @@ static int device_process_new(Manager *m, struct udev_device *dev) {
                 if (r < 0)
                         return log_warning_errno(r, "Failed to add parse SYSTEMD_ALIAS for %s: %m", sysfs);
 
-                if (path_is_absolute(word))
-                        (void) device_setup_unit(m, dev, word, false);
-                else
+                if (!path_is_absolute(word))
                         log_warning("SYSTEMD_ALIAS for %s is not an absolute path, ignoring: %s", sysfs, word);
+                else if (!path_is_normalized(word))
+                        log_warning("SYSTEMD_ALIAS for %s is not a normalized path, ignoring: %s", sysfs, word);
+                else
+                        (void) device_setup_unit(m, dev, word, false);
         }
 
         return 0;