From: Amaury Denoyelle <adenoyelle@haproxy.com>
Date: Thu, 23 Dec 2021 10:30:11 +0000 (+0100)
Subject: MINOR: quic: remove unnecessary call to free_quic_conn_cids()
X-Git-Tag: v2.6-dev1~228
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=a83729e9e606aa2ab4e78981799e001e2f38eb45;p=thirdparty%2Fhaproxy.git

MINOR: quic: remove unnecessary call to free_quic_conn_cids()

free_quic_conn_cids() was called in quic_build_post_handshake_frames()
if an error occured. However, the only error is an allocation failure of
the CID which does not required to call it.

This change is required for future refcount implementation. The CID lock
will be removed from the free_quic_conn_cids() and to the caller.
---

diff --git a/src/xprt_quic.c b/src/xprt_quic.c
index 500814fd1f..5874d1c354 100644
--- a/src/xprt_quic.c
+++ b/src/xprt_quic.c
@@ -2687,7 +2687,6 @@ static int quic_build_post_handshake_frames(struct quic_conn *qc)
     return 1;
 
  err:
-	free_quic_conn_cids(qc);
 	return 0;
 }