From: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com> Date: Sat, 13 Jun 2020 16:15:05 +0000 (-0700) Subject: bpo-40957: Fix refleak in _Py_fopen_obj() (GH-20827) X-Git-Tag: v3.8.4rc1~46 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=a8936fa5c09c039ad457dda8bdf733be6cc182e3;p=thirdparty%2FPython%2Fcpython.git bpo-40957: Fix refleak in _Py_fopen_obj() (GH-20827) Signed-off-by: Christian Heimes (cherry picked from commit 9672912e8f90374fd31b37ca0fb7cefbc6f4c555) Co-authored-by: Christian Heimes --- diff --git a/Misc/NEWS.d/next/Core and Builtins/2020-06-12-12-21-54.bpo-40957.Z8n6I6.rst b/Misc/NEWS.d/next/Core and Builtins/2020-06-12-12-21-54.bpo-40957.Z8n6I6.rst new file mode 100644 index 000000000000..f99c374f94aa --- /dev/null +++ b/Misc/NEWS.d/next/Core and Builtins/2020-06-12-12-21-54.bpo-40957.Z8n6I6.rst @@ -0,0 +1 @@ +Fix refleak in _Py_fopen_obj() when PySys_Audit() fails diff --git a/Python/fileutils.c b/Python/fileutils.c index e79e732d1f55..1021ddb58853 100644 --- a/Python/fileutils.c +++ b/Python/fileutils.c @@ -1461,6 +1461,7 @@ _Py_fopen_obj(PyObject *path, const char *mode) path_bytes = PyBytes_AS_STRING(bytes); if (PySys_Audit("open", "Osi", path, mode, 0) < 0) { + Py_DECREF(bytes); return NULL; }