From: Volker Lendecke <vl@samba.org>
Date: Wed, 31 Jul 2019 08:42:24 +0000 (+0200)
Subject: smbd: Fix the build with clang
X-Git-Tag: tdb-1.4.2~313
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=a8a1ca3f83dce6d725392989cbc97271cbf52f4a;p=thirdparty%2Fsamba.git

smbd: Fix the build with clang

clang correctly complains that "close_fsp" is used uninitialized if
"get_posix_fsp" fails and we end up in "goto out;".

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/source3/smbd/trans2.c b/source3/smbd/trans2.c
index 6ecd467a321..41f8dac13f0 100644
--- a/source3/smbd/trans2.c
+++ b/source3/smbd/trans2.c
@@ -4918,7 +4918,7 @@ static NTSTATUS smb_query_posix_acl(connection_struct *conn,
 	unsigned int size_needed = 0;
 	NTSTATUS status;
 	bool ok;
-	bool close_fsp;
+	bool close_fsp = false;
 
 	/*
 	 * Ensure we always operate on a file descriptor, not just