From: Greg Kroah-Hartman Date: Tue, 6 Apr 2010 23:48:13 +0000 (-0700) Subject: .33 stuff X-Git-Tag: v2.6.32.12~51 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=a90f0dd7a9bb74cd4d7f0e4be41f7cce732cfa6c;p=thirdparty%2Fkernel%2Fstable-queue.git .33 stuff --- diff --git a/queue-2.6.33/series b/queue-2.6.33/series index 8e2a8ca5eb2..d7a64dcb963 100644 --- a/queue-2.6.33/series +++ b/queue-2.6.33/series @@ -26,3 +26,4 @@ sunxvr500-ignore-secondary-output-pci-devices.patch watchdog-hpwdt-fix-lower-timeout-limit.patch watchdog-itco_wdt-tco-watchdog-patch-for-additional-intel-cougar-point-deviceids.patch genirq-force-msi-irq-handlers-to-run-with-interrupts-disabled.patch +tty-release_one_tty-forgets-to-put-pids.patch diff --git a/queue-2.6.33/tty-release_one_tty-forgets-to-put-pids.patch b/queue-2.6.33/tty-release_one_tty-forgets-to-put-pids.patch new file mode 100644 index 00000000000..f7cca3af80b --- /dev/null +++ b/queue-2.6.33/tty-release_one_tty-forgets-to-put-pids.patch @@ -0,0 +1,35 @@ +From 6da8d866d0d39e9509ff826660f6a86a6757c966 Mon Sep 17 00:00:00 2001 +From: Oleg Nesterov +Date: Fri, 2 Apr 2010 18:05:12 +0200 +Subject: tty: release_one_tty() forgets to put pids + +From: Oleg Nesterov + +commit 6da8d866d0d39e9509ff826660f6a86a6757c966 upstream. + +release_one_tty(tty) can be called when tty still has a reference +to pgrp/session. In this case we leak the pid. + +Signed-off-by: Oleg Nesterov +Reported-by: Catalin Marinas +Reported-and-tested-by: Tetsuo Handa +Acked-by: Linus Torvalds +Acked-by: Eric W. Biederman +Signed-off-by: Linus Torvalds +Signed-off-by: Greg Kroah-Hartman + +--- + drivers/char/tty_io.c | 2 ++ + 1 file changed, 2 insertions(+) + +--- a/drivers/char/tty_io.c ++++ b/drivers/char/tty_io.c +@@ -1423,6 +1423,8 @@ static void release_one_tty(struct work_ + list_del_init(&tty->tty_files); + file_list_unlock(); + ++ put_pid(tty->pgrp); ++ put_pid(tty->session); + free_tty_struct(tty); + } +