From: Zbigniew Jędrzejewski-Szmek <zbyszek@amutable.com>
Date: Tue, 5 May 2026 16:37:13 +0000 (+0200)
Subject: homectl: fix error handling in shell_is_ok()
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=a92b60ae17dc44e8f3777a933e3a901bca986ba5;p=thirdparty%2Fsystemd.git

homectl: fix error handling in shell_is_ok()

Fixes f233132a67a4c2c6dff053afac2385f570e8e3fe.
---

diff --git a/src/home/homectl.c b/src/home/homectl.c
index 37714aa2b01..454aa5bfe6b 100644
--- a/src/home/homectl.c
+++ b/src/home/homectl.c
@@ -2837,7 +2837,7 @@ static int shell_is_ok(const char *path, void *userdata) {
                 return false;
         }
 
-        r = chase_and_access(path, /* root= */ NULL, CHASE_MUST_BE_REGULAR, X_OK, /* ret_path= */ NULL) >= 0;
+        r = chase_and_access(path, /* root= */ NULL, CHASE_MUST_BE_REGULAR, X_OK, /* ret_path= */ NULL);
         if (r == -ENOENT) {
                 log_error_errno(r, "Shell '%s' does not exist, try again.", path);
                 return false;