From: Ben Harper <btharper1221@gmail.com>
Date: Tue, 10 Sep 2019 15:20:15 +0000 (-0400)
Subject: bpo-36253: Remove use after free reference in ctypes test suite (GH-12257)
X-Git-Tag: v3.9.0a1~587
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=a9b6033179b64b985394ad351501089a6a94fc9d;p=thirdparty%2FPython%2Fcpython.git

bpo-36253: Remove use after free reference in ctypes test suite (GH-12257)
---

diff --git a/Lib/ctypes/test/test_stringptr.py b/Lib/ctypes/test/test_stringptr.py
index 95cd1614c676..c20951f4ce00 100644
--- a/Lib/ctypes/test/test_stringptr.py
+++ b/Lib/ctypes/test/test_stringptr.py
@@ -70,8 +70,8 @@ class StringPtrTestCase(unittest.TestCase):
         x = r[0], r[1], r[2], r[3], r[4]
         self.assertEqual(x, (b"c", b"d", b"e", b"f", b"\000"))
         del buf
-        # x1 will NOT be the same as x, usually:
-        x1 = r[0], r[1], r[2], r[3], r[4]
+        # Because r is a pointer to memory that is freed after deleting buf,
+        # the pointer is hanging and using it would reference freed memory.
 
 if __name__ == '__main__':
     unittest.main()