From: YmrDtnJu <YmrDtnJu@users.noreply.github.com>
Date: Sun, 19 Jul 2020 15:04:46 +0000 (+0200)
Subject: networkd: Use NLM_F_ACK on the netlink message to add a neighbor.
X-Git-Tag: v246-rc2~47
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=a9c9b18a95486301ee9a1b6b7175cebd792fac89;p=thirdparty%2Fsystemd.git

networkd: Use NLM_F_ACK on the netlink message to add a neighbor.

sd_netlink_message_set_flags is called without NLM_F_ACK which results in
a timeout while networkd is waiting for an ACK that the kernel will never send.
---

diff --git a/src/network/networkd-neighbor.c b/src/network/networkd-neighbor.c
index 1c901138564..0e97b225c45 100644
--- a/src/network/networkd-neighbor.c
+++ b/src/network/networkd-neighbor.c
@@ -132,7 +132,7 @@ int neighbor_configure(Neighbor *neighbor, Link *link, link_netlink_message_hand
         if (r < 0)
                 return log_link_error_errno(link, r, "Could not set state: %m");
 
-        r = sd_netlink_message_set_flags(req, NLM_F_REQUEST | NLM_F_CREATE | NLM_F_REPLACE);
+        r = sd_netlink_message_set_flags(req, NLM_F_REQUEST | NLM_F_ACK | NLM_F_CREATE | NLM_F_REPLACE);
         if (r < 0)
                 return log_link_error_errno(link, r, "Could not set flags: %m");