From: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Date: Tue, 31 Oct 2023 01:14:30 +0000 (+0100)
Subject: [3.11] gh-111347: Remove wrong assertion in test_sendfile (GH-111377) (#111462)
X-Git-Tag: v3.11.7~114
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=a9d5966bce9bb347002d4da7672bf49fe4274ea4;p=thirdparty%2FPython%2Fcpython.git

[3.11] gh-111347: Remove wrong assertion in test_sendfile (GH-111377) (#111462)

gh-111347: Remove wrong assertion in test_sendfile (GH-111377)

Windows is different.
(cherry picked from commit fa35b9e89b2e207fc8bae9eb0284260d0d922e7a)

Co-authored-by: zcxsythenew <30565051+zcxsythenew@users.noreply.github.com>
---

diff --git a/Lib/test/test_asyncio/test_sendfile.py b/Lib/test/test_asyncio/test_sendfile.py
index 0198da21d770..d33ff197bbfa 100644
--- a/Lib/test/test_asyncio/test_sendfile.py
+++ b/Lib/test/test_asyncio/test_sendfile.py
@@ -470,8 +470,11 @@ class SendfileMixin(SendfileBase):
 
         self.assertTrue(1024 <= srv_proto.nbytes < len(self.DATA),
                         srv_proto.nbytes)
-        self.assertTrue(1024 <= self.file.tell() < len(self.DATA),
-                        self.file.tell())
+        if not (sys.platform == 'win32'
+                and isinstance(self.loop, asyncio.ProactorEventLoop)):
+            # On Windows, Proactor uses transmitFile, which does not update tell()
+            self.assertTrue(1024 <= self.file.tell() < len(self.DATA),
+                            self.file.tell())
         self.assertTrue(cli_proto.transport.is_closing())
 
     def test_sendfile_fallback_close_peer_in_the_middle_of_receiving(self):