From: Volker Lendecke <vl@samba.org>
Date: Tue, 25 Mar 2008 21:35:20 +0000 (+0100)
Subject: Fix a valgrind error
X-Git-Tag: samba-3.3.0pre1~3120
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=aa4377561b691e2c5108c18aeb34fff39d8775df;p=thirdparty%2Fsamba.git

Fix a valgrind error

In winbind, we're using the info3 struct to send it to the winbind client after
netsamlogon_cache_store. Without this info3->base.account_name.string was
prematurely freed.
---

diff --git a/source/libsmb/samlogon_cache.c b/source/libsmb/samlogon_cache.c
index 73b570c3834..235880910cd 100644
--- a/source/libsmb/samlogon_cache.c
+++ b/source/libsmb/samlogon_cache.c
@@ -149,7 +149,7 @@ bool netsamlogon_cache_store(const char *username, struct netr_SamInfo3 *info3)
 	/* so we fill it in since winbindd_getpwnam() makes use of it */
 
 	if (!info3->base.account_name.string) {
-		info3->base.account_name.string = talloc_strdup(mem_ctx, username);
+		info3->base.account_name.string = talloc_strdup(info3, username);
 	}
 
 	r.timestamp = t;