From: Serhiy Storchaka <storchaka@gmail.com>
Date: Mon, 27 Nov 2023 17:53:43 +0000 (+0200)
Subject: gh-111789: Use PyDict_GetItemRef() in Python/codecs.c (gh-112082)
X-Git-Tag: v3.13.0a3~622
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=aa438bdd6deed225d30d87dc3a77602ffc924213;p=thirdparty%2FPython%2Fcpython.git

gh-111789: Use PyDict_GetItemRef() in Python/codecs.c (gh-112082)
---

diff --git a/Python/codecs.c b/Python/codecs.c
index b79bf555f2f2..545bf82e00dc 100644
--- a/Python/codecs.c
+++ b/Python/codecs.c
@@ -146,15 +146,14 @@ PyObject *_PyCodec_Lookup(const char *encoding)
     PyUnicode_InternInPlace(&v);
 
     /* First, try to lookup the name in the registry dictionary */
-    PyObject *result = PyDict_GetItemWithError(interp->codec_search_cache, v);
+    PyObject *result;
+    if (PyDict_GetItemRef(interp->codec_search_cache, v, &result) < 0) {
+        goto onError;
+    }
     if (result != NULL) {
-        Py_INCREF(result);
         Py_DECREF(v);
         return result;
     }
-    else if (PyErr_Occurred()) {
-        goto onError;
-    }
 
     /* Next, scan the search functions in order of registration */
     const Py_ssize_t len = PyList_Size(interp->codec_search_path);