From: Paulo Alcantara <pc@manguebit.com>
Date: Tue, 2 Apr 2024 19:34:02 +0000 (-0300)
Subject: smb: client: fix potential UAF in smb2_is_network_name_deleted()
X-Git-Tag: v6.6.26~27
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=aa582b33f94453fdeaff1e7d0aa252c505975e01;p=thirdparty%2Fkernel%2Fstable.git

smb: client: fix potential UAF in smb2_is_network_name_deleted()

commit 63981561ffd2d4987807df4126f96a11e18b0c1d upstream.

Skip sessions that are being teared down (status == SES_EXITING) to
avoid UAF.

Cc: stable@vger.kernel.org
Signed-off-by: Paulo Alcantara (Red Hat) <pc@manguebit.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/fs/smb/client/smb2ops.c b/fs/smb/client/smb2ops.c
index a07b74935583a..04fea874d0a33 100644
--- a/fs/smb/client/smb2ops.c
+++ b/fs/smb/client/smb2ops.c
@@ -2430,6 +2430,8 @@ smb2_is_network_name_deleted(char *buf, struct TCP_Server_Info *server)
 
 	spin_lock(&cifs_tcp_ses_lock);
 	list_for_each_entry(ses, &pserver->smb_ses_list, smb_ses_list) {
+		if (cifs_ses_exiting(ses))
+			continue;
 		list_for_each_entry(tcon, &ses->tcon_list, tcon_list) {
 			if (tcon->tid == le32_to_cpu(shdr->Id.SyncId.TreeId)) {
 				spin_lock(&tcon->tc_lock);