From: Daniel Stenberg <daniel@haxx.se>
Date: Mon, 10 Mar 2025 11:09:00 +0000 (+0100)
Subject: socks: remove bad assert from do_SOCKS5()
X-Git-Tag: curl-8_13_0~194
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=aa8d1d648e40d6db1e27e029aefa57e61154f43f;p=thirdparty%2Fcurl.git

socks: remove bad assert from do_SOCKS5()

It verified the auth bits wrongly. We don't need this assert anymore
since the input is verified in *setopt().

Bug: https://issues.oss-fuzz.com/issues/401869346

Closes #16650
---

diff --git a/lib/socks.c b/lib/socks.c
index 30a73112c3..cb198df1ce 100644
--- a/lib/socks.c
+++ b/lib/socks.c
@@ -590,7 +590,6 @@ static CURLproxycode do_SOCKS5(struct Curl_cfilter *cf,
   bool allow_gssapi = FALSE;
   struct Curl_dns_entry *dns = NULL;
 
-  DEBUGASSERT(auth & (CURLAUTH_BASIC | CURLAUTH_GSSAPI));
   switch(sx->state) {
   case CONNECT_SOCKS_INIT:
     if(conn->bits.httpproxy)