From: Abdul Date: Mon, 15 Sep 2025 11:13:37 +0000 (+0100) Subject: gh-137017: Ensure `Thread.is_alive()` only returns False after the underlying OS... X-Git-Tag: v3.15.0a1~369 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=aa9ceb17215af21ed6618d6f7ccb5bf57ca57101;p=thirdparty%2FPython%2Fcpython.git gh-137017: Ensure `Thread.is_alive()` only returns False after the underlying OS thread exits (gh-137315) --- diff --git a/Misc/NEWS.d/next/Library/2025-08-01-23-11-25.gh-issue-137017.0yGcNc.rst b/Misc/NEWS.d/next/Library/2025-08-01-23-11-25.gh-issue-137017.0yGcNc.rst new file mode 100644 index 000000000000..7c2c013016d7 --- /dev/null +++ b/Misc/NEWS.d/next/Library/2025-08-01-23-11-25.gh-issue-137017.0yGcNc.rst @@ -0,0 +1,3 @@ +Fix :obj:`threading.Thread.is_alive` to remain ``True`` until the underlying OS +thread is fully cleaned up. This avoids false negatives in edge cases +involving thread monitoring or premature :obj:`threading.Thread.is_alive` calls. diff --git a/Modules/_threadmodule.c b/Modules/_threadmodule.c index a436a553db98..c6d07b136071 100644 --- a/Modules/_threadmodule.c +++ b/Modules/_threadmodule.c @@ -711,6 +711,9 @@ PyThreadHandleObject_is_done(PyObject *op, PyObject *Py_UNUSED(dummy)) { PyThreadHandleObject *self = PyThreadHandleObject_CAST(op); if (_PyEvent_IsSet(&self->handle->thread_is_exiting)) { + if (_PyOnceFlag_CallOnce(&self->handle->once, join_thread, self->handle) == -1) { + return NULL; + } Py_RETURN_TRUE; } else {