From: Joseph Sutton <josephsutton@catalyst.net.nz>
Date: Thu, 21 Sep 2023 02:21:55 +0000 (+1200)
Subject: s4:auth: Fix ‘user_info_dc_out’ leak
X-Git-Tag: tevent-0.16.0~351
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=ab227bbe8e4b344bb54c5fc656d2835ef1c03c83;p=thirdparty%2Fsamba.git

s4:auth: Fix ‘user_info_dc_out’ leak

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/source4/auth/kerberos/kerberos_pac.c b/source4/auth/kerberos/kerberos_pac.c
index 46b9b235854..4f291d81064 100644
--- a/source4/auth/kerberos/kerberos_pac.c
+++ b/source4/auth/kerberos/kerberos_pac.c
@@ -392,7 +392,7 @@ krb5_error_code kerberos_pac_to_user_info_dc(TALLOC_CTX *mem_ctx,
 	}
 
 	/* Pull this right into the normal auth system structures */
-	nt_status = make_user_info_dc_pac(mem_ctx,
+	nt_status = make_user_info_dc_pac(tmp_ctx,
 					 info.logon_info.info,
 					 upn_dns_info,
 					 group_inclusion,
@@ -492,7 +492,7 @@ krb5_error_code kerberos_pac_to_user_info_dc(TALLOC_CTX *mem_ctx,
 		};
 	}
 
-	*user_info_dc = user_info_dc_out;
+	*user_info_dc = talloc_steal(mem_ctx, user_info_dc_out);
 	if (resource_groups_out != NULL) {
 		*resource_groups = talloc_steal(mem_ctx, resource_groups_out);
 	}