From: Ondřej Surý <ondrej@isc.org>
Date: Mon, 3 Jan 2022 20:37:54 +0000 (+0100)
Subject: Add isc_refcount_destroy() for dns_zt reference counters
X-Git-Tag: v9.17.22~10^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=ab5b2ef43c86fcbf0385148d18411c915e3a0399;p=thirdparty%2Fbind9.git

Add isc_refcount_destroy() for dns_zt reference counters

The zt_destroy() function was missing isc_refcount_destroy() on the two
reference counters.  The isc_refcount_destroy() adds proper memory
ordering on destroy and also ensures that the reference counters have
been zeroed before destroying the object.
---

diff --git a/lib/dns/zt.c b/lib/dns/zt.c
index d4ff6fa53fa..2c569dde13e 100644
--- a/lib/dns/zt.c
+++ b/lib/dns/zt.c
@@ -222,6 +222,9 @@ flush(dns_zone_t *zone, void *uap) {
 
 static void
 zt_destroy(dns_zt_t *zt) {
+	isc_refcount_destroy(&zt->references);
+	isc_refcount_destroy(&zt->loads_pending);
+
 	if (atomic_load_acquire(&zt->flush)) {
 		(void)dns_zt_apply(zt, false, NULL, flush, NULL);
 	}