From: Volker Lendecke <vl@samba.org>
Date: Tue, 15 Aug 2017 04:02:13 +0000 (+0200)
Subject: nfs4acls: Slightly simplify smb_add_ace4
X-Git-Tag: tevent-0.9.34~112
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=abcb98343020d771ce1ae99f034b137fbce0d2b3;p=thirdparty%2Fsamba.git

nfs4acls: Slightly simplify smb_add_ace4

The comment was a bit confusing to me, it took a few seconds too many to figure
out *why* setting NULL is not required. Remove it :-)

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
---

diff --git a/source3/modules/nfs4_acls.c b/source3/modules/nfs4_acls.c
index 538517f4a3c..19f0fefdb98 100644
--- a/source3/modules/nfs4_acls.c
+++ b/source3/modules/nfs4_acls.c
@@ -184,8 +184,7 @@ struct SMB4ACE_T *smb_add_ace4(struct SMB4ACL_T *acl, SMB_ACE4PROP_T *prop)
 		errno = ENOMEM;
 		return NULL;
 	}
-	/* ace->next = NULL not needed */
-	memcpy(&ace->prop, prop, sizeof(SMB_ACE4PROP_T));
+	ace->prop = *prop;
 
 	if (acl->first==NULL)
 	{