From: Joseph Sutton <josephsutton@catalyst.net.nz>
Date: Fri, 6 Oct 2023 02:31:47 +0000 (+1300)
Subject: s3:utils: Check return value of cli_RNetServiceEnum() (CID 1273313)
X-Git-Tag: tevent-0.16.0~57
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=ac00851fc9fd3f5375f15002fbe0793623d1b06e;p=thirdparty%2Fsamba.git

s3:utils: Check return value of cli_RNetServiceEnum() (CID 1273313)

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/source3/utils/net_rap.c b/source3/utils/net_rap.c
index 8f07106927c..9818623a925 100644
--- a/source3/utils/net_rap.c
+++ b/source3/utils/net_rap.c
@@ -1214,6 +1214,10 @@ int net_rap_service(struct net_context *c, int argc, const char **argv)
 			d_printf(_("Service name          Comment\n"
 		                   "-----------------------------\n"));
 			ret = cli_RNetServiceEnum(cli, long_group_fn, NULL);
+			if (ret) {
+				cli_shutdown(cli);
+				return ret;
+			}
 		}
 		ret = cli_RNetServiceEnum(cli, service_fn, NULL);
 		cli_shutdown(cli);