From: Victor Stinner <vstinner@python.org>
Date: Sat, 4 Nov 2023 00:47:07 +0000 (+0100)
Subject: gh-111644: Fix asyncio test_unhandled_exceptions() (#111713)
X-Git-Tag: v3.13.0a2~197
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=ac01e2243a1104b2154c0d1bdbc9f8d5b3ada778;p=thirdparty%2FPython%2Fcpython.git

gh-111644: Fix asyncio test_unhandled_exceptions() (#111713)

Fix test_unhandled_exceptions() of test_asyncio.test_streams: break
explicitly a reference cycle.

Fix also StreamTests.tearDown(): the loop must not be closed
explicitly, but using set_event_loop() which takes care of shutting
down the executor with executor.shutdown(wait=True).
BaseEventLoop.close() calls executor.shutdown(wait=False).
---

diff --git a/Lib/test/test_asyncio/test_streams.py b/Lib/test/test_asyncio/test_streams.py
index c477b6c838c5..3fea7b9f6911 100644
--- a/Lib/test/test_asyncio/test_streams.py
+++ b/Lib/test/test_asyncio/test_streams.py
@@ -37,8 +37,7 @@ class StreamTests(test_utils.TestCase):
         # just in case if we have transport close callbacks
         test_utils.run_briefly(self.loop)
 
-        self.loop.close()
-        gc.collect()
+        # set_event_loop() takes care of closing self.loop in a safe way
         super().tearDown()
 
     def _basetest_open_connection(self, open_connection_fut):
@@ -1124,6 +1123,8 @@ os.close(fd)
 
         self.assertEqual(messages[0]['message'],
                          'Unhandled exception in client_connected_cb')
+        # Break explicitly reference cycle
+        messages = None
 
 
 if __name__ == '__main__':