From: Thomas Markwalder <tmark@isc.org>
Date: Thu, 24 Apr 2014 14:04:02 +0000 (-0400)
Subject: [3121] Addressed review comments
X-Git-Tag: trac3434_base~46^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=ac5e4786cc8ce2ebdd5c8ea436b36ae96dd164e1;p=thirdparty%2Fkea.git

[3121] Addressed review comments

Added suggested code commentary.
---

diff --git a/src/bin/d2/d2_config.cc b/src/bin/d2/d2_config.cc
index 1faa81900c..fbfbf763d3 100644
--- a/src/bin/d2/d2_config.cc
+++ b/src/bin/d2/d2_config.cc
@@ -265,8 +265,9 @@ TSIGKeyInfoParser::createConfigParser(const std::string& config_id) {
 
 void
 TSIGKeyInfoParser::commit() {
-    /// @todo if at some point  TSIG keys need some form of resource
-    /// initialization do that here
+    /// @todo if at some point  TSIG keys need some form of runtime resource
+    /// initialization, such as creating some sort of hash instance in
+    /// crytpolib.  Once TSIG is fully implemented under Trac #3432 we'll know.
 }
 
 // *********************** TSIGKeyInfoListParser  *************************
diff --git a/src/bin/d2/d2_config.h b/src/bin/d2/d2_config.h
index 9babcd243a..5af60eee80 100644
--- a/src/bin/d2/d2_config.h
+++ b/src/bin/d2/d2_config.h
@@ -561,6 +561,8 @@ public:
     virtual isc::dhcp::ParserPtr createConfigParser(const std::string&
                                                     config_id);
     /// @brief Commits the TSIGKeyInfo configuration
+    /// Currently this method is a NOP, as the key instance is created and
+    /// then added to a local list of keys in build().
     virtual void commit();
 
 private:
@@ -613,7 +615,8 @@ public:
     /// @brief Commits the list of TSIG keys
     ///
     /// Iterates over the internal list of TSIGKeyInfoParsers, invoking
-    /// commit on each one.
+    /// commit on each one.  Then commits the local list of keys to
+    /// storage.
     virtual void commit();
 
 private:
@@ -675,6 +678,8 @@ public:
                                                     config_id);
 
     /// @brief Commits the configured DnsServerInfo
+    /// Currently this method is a NOP, as the server instance is created and
+    /// then added to the list of servers in build().
     virtual void commit();
 
 private:
@@ -788,6 +793,8 @@ public:
                                                     config_id);
 
     /// @brief Commits the configured DdnsDomain
+    /// Currently this method is a NOP, as the domain instance is created and
+    /// then added to the list of domains in build().
     virtual void commit();
 
 private:
@@ -920,6 +927,8 @@ public:
                                                     config_id);
 
     /// @brief Commits the configured DdsnDomainListMgr
+    /// Currently this method is a NOP, as the manager instance is created
+    /// in build().
     virtual void commit();
 
 private: