From: Luigi Rizzo <rizzo@icir.org>
Date: Fri, 6 Oct 2006 20:16:13 +0000 (+0000)
Subject: simplify logic in preparation to reduce indentation
X-Git-Tag: 1.6.0-beta1~3^2~4491
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=acd10739092cb0e1160733615aa24ddcd5fb87f1;p=thirdparty%2Fasterisk.git

simplify logic in preparation to reduce indentation



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44616 65c4cc65-6c06-0410-ace0-fbb531ad65f3
---

diff --git a/main/manager.c b/main/manager.c
index f0fa6400ce..0a6b098e5c 100644
--- a/main/manager.c
+++ b/main/manager.c
@@ -862,11 +862,13 @@ static int authenticate(struct mansession *s, struct message *m)
 	cfg = ast_config_load("manager.conf");
 	if (!cfg)
 		return -1;
-	cat = ast_category_browse(cfg, NULL);
-	while (cat) {
-		if (strcasecmp(cat, "general")) {
-			/* This is a user */
-			if (!strcasecmp(cat, user)) {
+	cat = NULL;
+	while ( (cat = ast_category_browse(cfg, cat)) ) {
+		if (!strcasecmp(cat, "general") || strcasecmp(cat, user))
+			continue;	/* skip 'general' and non-matching sections */
+
+		/* XXX fix indentation */
+		{
 				struct ast_variable *v;
 				struct ast_ha *ha = NULL;
 				char *password = NULL;
@@ -929,9 +931,7 @@ static int authenticate(struct mansession *s, struct message *m)
 					ast_config_destroy(cfg);
 					return -1;
 				}	
-			}
 		}
-		cat = ast_category_browse(cfg, cat);
 	}
 	if (cat) {
 		ast_copy_string(s->username, cat, sizeof(s->username));