From: Serhiy Storchaka <storchaka@gmail.com>
Date: Fri, 23 Feb 2024 11:35:27 +0000 (+0200)
Subject: gh-111789: Use PyDict_GetItemRef() in Python/compile.c (GH-112083)
X-Git-Tag: v3.13.0a5~271
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=acd6f41ecf9987c21c3d238d5496b17857c05482;p=thirdparty%2FPython%2Fcpython.git

gh-111789: Use PyDict_GetItemRef() in Python/compile.c (GH-112083)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
---

diff --git a/Python/compile.c b/Python/compile.c
index d857239690e7..6b17f3bcaf22 100644
--- a/Python/compile.c
+++ b/Python/compile.c
@@ -921,11 +921,10 @@ dict_add_o(PyObject *dict, PyObject *o)
     PyObject *v;
     Py_ssize_t arg;
 
-    v = PyDict_GetItemWithError(dict, o);
+    if (PyDict_GetItemRef(dict, o, &v) < 0) {
+        return ERROR;
+    }
     if (!v) {
-        if (PyErr_Occurred()) {
-            return ERROR;
-        }
         arg = PyDict_GET_SIZE(dict);
         v = PyLong_FromSsize_t(arg);
         if (!v) {
@@ -935,10 +934,10 @@ dict_add_o(PyObject *dict, PyObject *o)
             Py_DECREF(v);
             return ERROR;
         }
-        Py_DECREF(v);
     }
     else
         arg = PyLong_AsLong(v);
+    Py_DECREF(v);
     return arg;
 }