From: Volker Lendecke <vl@samba.org>
Date: Tue, 5 Sep 2023 12:44:37 +0000 (+0200)
Subject: smbd: Don't change incoming flags in open_file()
X-Git-Tag: tevent-0.16.0~230
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=ad7b119b8be325c8d140676f535042f87aecf1ae;p=thirdparty%2Fsamba.git

smbd: Don't change incoming flags in open_file()

This will be part of a const struct vfs_open_how soon. Further down in
this function we don't look at O_CREAT or O_EXCL of "flags" anymore
anyway.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
---

diff --git a/source3/smbd/open.c b/source3/smbd/open.c
index be42f9430f1..efcd0ceec8e 100644
--- a/source3/smbd/open.c
+++ b/source3/smbd/open.c
@@ -1360,7 +1360,6 @@ static NTSTATUS open_file(struct smb_request *req,
 			   O_CREAT doesn't create the file if we have write
 			   access into the directory.
 			*/
-			flags &= ~(O_CREAT|O_EXCL);
 			local_flags &= ~(O_CREAT|O_EXCL);
 		}
 	}