From: Carl Meyer <carl@oddbird.net>
Date: Mon, 10 Oct 2022 01:59:07 +0000 (+0200)
Subject: bpo-43564: preserve original exception in args of FTP URLError (#24938)
X-Git-Tag: v3.12.0a1~142
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=ad817cd5c44416da3752ebf9baf16d650703275c;p=thirdparty%2FPython%2Fcpython.git

bpo-43564: preserve original exception in args of FTP URLError (#24938)

* bpo-43564: preserve original error in args of FTP URLError

* Add NEWS blurb

Co-authored-by: Carl Meyer <carljm@instagram.com>
---

diff --git a/Lib/urllib/request.py b/Lib/urllib/request.py
index e2d5b8c5c59a..278aa3a14bfe 100644
--- a/Lib/urllib/request.py
+++ b/Lib/urllib/request.py
@@ -1582,7 +1582,7 @@ class FTPHandler(BaseHandler):
             headers = email.message_from_string(headers)
             return addinfourl(fp, headers, req.full_url)
         except ftplib.all_errors as exp:
-            raise URLError(f'ftp error: {exp}') from exp
+            raise URLError(exp) from exp
 
     def connect_ftp(self, user, passwd, host, port, dirs, timeout):
         return ftpwrapper(user, passwd, host, port, dirs, timeout,
diff --git a/Misc/NEWS.d/next/Library/2022-10-09-12-12-38.gh-issue-87730.ClgP3f.rst b/Misc/NEWS.d/next/Library/2022-10-09-12-12-38.gh-issue-87730.ClgP3f.rst
new file mode 100644
index 000000000000..6c63fa4928c6
--- /dev/null
+++ b/Misc/NEWS.d/next/Library/2022-10-09-12-12-38.gh-issue-87730.ClgP3f.rst
@@ -0,0 +1,3 @@
+Wrap network errors consistently in urllib FTP support, so the test suite
+doesn't fail when a network is available but the public internet is not
+reachable.