From: Richard Guenther Date: Wed, 15 Apr 2009 16:12:01 +0000 (+0000) Subject: omp-low.c (lower_rec_input_clauses): Build correct address expressions. X-Git-Tag: releases/gcc-4.5.0~6582 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=ada39f0b23c61dd0c3acc45c73910b07c9fc03f3;p=thirdparty%2Fgcc.git omp-low.c (lower_rec_input_clauses): Build correct address expressions. 2009-04-15 Richard Guenther * omp-low.c (lower_rec_input_clauses): Build correct address expressions. (expand_omp_for_generic): Fix multiplication type. * tree-loop-distribution.c (build_size_arg): Build a size_t argument. (generate_memset_zero): Fix types. * tree-profile.c (prepare_instrumented_value): Correctly widen a pointer. From-SVN: r146129 --- diff --git a/gcc/ChangeLog b/gcc/ChangeLog index eb0ccb13689b..7df2ef940c28 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,14 @@ +2009-04-15 Richard Guenther + + * omp-low.c (lower_rec_input_clauses): Build correct address + expressions. + (expand_omp_for_generic): Fix multiplication type. + * tree-loop-distribution.c (build_size_arg): Build a + size_t argument. + (generate_memset_zero): Fix types. + * tree-profile.c (prepare_instrumented_value): Correctly + widen a pointer. + 2009-04-15 Ian Lance Taylor * c.opt (Wenum-compare): Enable for C and Objc. Initialize to -1. diff --git a/gcc/omp-low.c b/gcc/omp-low.c index be0153fea424..c28bbb0a1cae 100644 --- a/gcc/omp-low.c +++ b/gcc/omp-low.c @@ -2318,14 +2318,14 @@ lower_rec_input_clauses (tree clauses, gimple_seq *ilist, gimple_seq *dlist, name); gimple_add_tmp_var (x); TREE_ADDRESSABLE (x) = 1; - x = build_fold_addr_expr_with_type (x, TREE_TYPE (new_var)); + x = build_fold_addr_expr (x); } else { x = build_call_expr (built_in_decls[BUILT_IN_ALLOCA], 1, x); - x = fold_convert (TREE_TYPE (new_var), x); } + x = fold_convert (TREE_TYPE (new_var), x); gimplify_assign (new_var, x, ilist); new_var = build_fold_indirect_ref (new_var); @@ -3843,7 +3843,8 @@ expand_omp_for_generic (struct omp_region *region, itype = lang_hooks.types.type_for_size (TYPE_PRECISION (vtype), 0); t = fold_build2 (TRUNC_MOD_EXPR, type, tem, counts[i]); t = fold_convert (itype, t); - t = fold_build2 (MULT_EXPR, itype, t, fd->loops[i].step); + t = fold_build2 (MULT_EXPR, itype, t, + fold_convert (itype, fd->loops[i].step)); if (POINTER_TYPE_P (vtype)) t = fold_build2 (POINTER_PLUS_EXPR, vtype, fd->loops[i].n1, fold_convert (sizetype, t)); diff --git a/gcc/tree-loop-distribution.c b/gcc/tree-loop-distribution.c index 61762971c7cd..a5c73165cb49 100644 --- a/gcc/tree-loop-distribution.c +++ b/gcc/tree-loop-distribution.c @@ -216,7 +216,7 @@ generate_loops_for_partition (struct loop *loop, bitmap partition, bool copy_p) return true; } -/* Build size argument. */ +/* Build the size argument for a memset call. */ static inline tree build_size_arg (tree nb_iter, tree op, gimple_seq* stmt_list) @@ -224,8 +224,10 @@ build_size_arg (tree nb_iter, tree op, gimple_seq* stmt_list) tree nb_bytes; gimple_seq stmts = NULL; - nb_bytes = fold_build2 (MULT_EXPR, TREE_TYPE (nb_iter), - nb_iter, TYPE_SIZE_UNIT (TREE_TYPE (op))); + nb_bytes = fold_build2 (MULT_EXPR, size_type_node, + fold_convert (size_type_node, nb_iter), + fold_convert (size_type_node, + TYPE_SIZE_UNIT (TREE_TYPE (op)))); nb_bytes = force_gimple_operand (nb_bytes, &stmts, true, NULL); gimple_seq_add_seq (stmt_list, stmts); @@ -272,7 +274,8 @@ generate_memset_zero (gimple stmt, tree op0, tree nb_iter, { nb_bytes = build_size_arg (nb_iter, op0, &stmt_list); addr_base = size_binop (PLUS_EXPR, DR_OFFSET (dr), DR_INIT (dr)); - addr_base = fold_build2 (MINUS_EXPR, sizetype, addr_base, nb_bytes); + addr_base = fold_build2 (MINUS_EXPR, sizetype, addr_base, + fold_convert (sizetype, nb_bytes)); addr_base = force_gimple_operand (addr_base, &stmts, true, NULL); gimple_seq_add_seq (&stmt_list, stmts); @@ -291,7 +294,7 @@ generate_memset_zero (gimple stmt, tree op0, tree nb_iter, fn = build1 (ADDR_EXPR, build_pointer_type (fntype), fndecl); if (!nb_bytes) - nb_bytes = build_size_arg (nb_iter, op0, &stmt_list); + nb_bytes = build_size_arg (nb_iter, op0, &stmt_list); fn_call = gimple_build_call (fn, 3, mem, integer_zero_node, nb_bytes); gimple_seq_add_stmt (&stmt_list, fn_call); diff --git a/gcc/tree-profile.c b/gcc/tree-profile.c index 06f113bea091..8ffedf1823ed 100644 --- a/gcc/tree-profile.c +++ b/gcc/tree-profile.c @@ -208,6 +208,8 @@ static tree prepare_instrumented_value (gimple_stmt_iterator *gsi, histogram_value value) { tree val = value->hvalue.value; + if (POINTER_TYPE_P (TREE_TYPE (val))) + val = fold_convert (sizetype, val); return force_gimple_operand_gsi (gsi, fold_convert (gcov_type_node, val), true, NULL_TREE, true, GSI_SAME_STMT); }