From: Matthijs Mekking <matthijs@isc.org>
Date: Tue, 30 Apr 2024 15:36:47 +0000 (+0200)
Subject: Add a unit test case for converting \000\009
X-Git-Tag: v9.19.24~4^2~3
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=ada46eb9f584b59046734bfbe1a71fe77cfd14e9;p=thirdparty%2Fbind9.git

Add a unit test case for converting \000\009

Sanity checking that this domain converts to the key I am expecting.

Also fix some of the other names that had trailing 0x02 bits.
---

diff --git a/tests/dns/qp_test.c b/tests/dns/qp_test.c
index efd14703607..dc053f8b90f 100644
--- a/tests/dns/qp_test.c
+++ b/tests/dns/qp_test.c
@@ -56,9 +56,14 @@ ISC_RUN_TEST_IMPL(qpkey_name) {
 		},
 		{
 			.namestr = "\\000",
-			.key = { 0x03, 0x03, 0x02, 0x02 },
+			.key = { 0x03, 0x03, 0x02 },
 			.len = 3,
 		},
+		{
+			.namestr = "\\000\\009",
+			.key = { 0x03, 0x03, 0x03, 0x0c, 0x02 },
+			.len = 5,
+		},
 		{
 			.namestr = "com",
 			.key = { 0x16, 0x22, 0x20, 0x02 },
@@ -72,19 +77,19 @@ ISC_RUN_TEST_IMPL(qpkey_name) {
 		{
 			.namestr = "example.com.",
 			.key = { 0x02, 0x16, 0x22, 0x20, 0x02, 0x18, 0x2b, 0x14,
-				 0x20, 0x23, 0x1f, 0x18, 0x02, 0x02 },
+				 0x20, 0x23, 0x1f, 0x18, 0x02 },
 			.len = 13,
 		},
 		{
 			.namestr = "example.com",
 			.key = { 0x16, 0x22, 0x20, 0x02, 0x18, 0x2b, 0x14, 0x20,
-				 0x23, 0x1f, 0x18, 0x02, 0x02 },
+				 0x23, 0x1f, 0x18, 0x02 },
 			.len = 12,
 		},
 		{
 			.namestr = "EXAMPLE.COM",
 			.key = { 0x16, 0x22, 0x20, 0x02, 0x18, 0x2b, 0x14, 0x20,
-				 0x23, 0x1f, 0x18, 0x02, 0x02 },
+				 0x23, 0x1f, 0x18, 0x02 },
 			.len = 12,
 		},
 	};
@@ -128,6 +133,9 @@ ISC_RUN_TEST_IMPL(qpkey_sort) {
 	} testcases[] = {
 		{ .namestr = "." },
 		{ .namestr = "\\000." },
+		{ .namestr = "\\000.\\000." },
+		{ .namestr = "\\000\\009." },
+		{ .namestr = "\\007." },
 		{ .namestr = "example.com." },
 		{ .namestr = "EXAMPLE.COM." },
 		{ .namestr = "www.example.com." },