From: Julian Seward Date: Fri, 14 Aug 2009 21:33:34 +0000 (+0000) Subject: Double the maximum size of the conflict cache. X-Git-Tag: svn/VALGRIND_3_5_0~33 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=adbc233c4db872de8ed1603e18ea944f3ca73a06;p=thirdparty%2Fvalgrind.git Double the maximum size of the conflict cache. git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10817 --- diff --git a/helgrind/docs/hg-manual.xml b/helgrind/docs/hg-manual.xml index d45664bccb..41ba083c3c 100644 --- a/helgrind/docs/hg-manual.xml +++ b/helgrind/docs/hg-manual.xml @@ -1005,11 +1005,11 @@ unlock(mx) unlock(mx) conflicting access information is stored. If you find that Helgrind is showing race errors with only one stack instead of the expected two stacks, try increasing this value. - The minimum value is 10,000 and the maximum is 10,000,000 - (ten times the default value). Increasing the value by 1 + The minimum value is 10,000 and the maximum is 20,000,000 + (twenty times the default value). Increasing the value by 1 increases Helgrind's memory requirement by very roughly 100 - bytes, so the maximum value will easily eat up an extra - gigabyte or so of memory. + bytes, so the maximum value will easily eat up two extra + gigabytes or so of memory. diff --git a/helgrind/hg_main.c b/helgrind/hg_main.c index ee72e30745..3a53f7129e 100644 --- a/helgrind/hg_main.c +++ b/helgrind/hg_main.c @@ -4397,10 +4397,10 @@ static Bool hg_process_cmd_line_option ( Char* arg ) else if VG_XACT_CLO(arg, "--history-level=full", HG_(clo_history_level), 2); - /* If you change the 10k/10mill limits, remember to also change + /* If you change the 10k/20mill limits, remember to also change them in assertions at the top of event_map_maybe_GC. */ else if VG_BINT_CLO(arg, "--conflict-cache-size", - HG_(clo_conflict_cache_size), 10*1000, 10*1000*1000) {} + HG_(clo_conflict_cache_size), 10*1000, 20*1000*1000) {} /* "stuvwx" --> stuvwx (binary) */ else if VG_STR_CLO(arg, "--hg-sanity-flags", tmp_str) { diff --git a/helgrind/libhb_core.c b/helgrind/libhb_core.c index 3a5f7c60d0..7b0e97621e 100644 --- a/helgrind/libhb_core.c +++ b/helgrind/libhb_core.c @@ -3797,7 +3797,7 @@ static void event_map_maybe_GC ( void ) /* Check for sane command line params. Limit values must match those in hg_process_cmd_line_option. */ tl_assert( HG_(clo_conflict_cache_size) >= 10*1000 ); - tl_assert( HG_(clo_conflict_cache_size) <= 10*1000*1000 ); + tl_assert( HG_(clo_conflict_cache_size) <= 20*1000*1000 ); /* Check our counting is sane (expensive) */ if (CHECK_CEM)