From: Darrick J. Wong <djwong@kernel.org>
Date: Tue, 23 Sep 2025 17:08:57 +0000 (-0700)
Subject: mkfs: fix libxfs_iget return value sign inversion
X-Git-Tag: v6.17.0~16
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=add1e9d2f576a3222faba16a11868eb178d2ba86;p=thirdparty%2Fxfsprogs-dev.git

mkfs: fix libxfs_iget return value sign inversion

libxfs functions return negative errno, so utilities must invert the
return values from such functions.  Caught by xfs/437.

Fixes: 8a4ea72724930c ("proto: add ability to populate a filesystem from a directory")
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Andrey Albershteyn <aalbersh@kernel.org>
---

diff --git a/mkfs/proto.c b/mkfs/proto.c
index bfeeb5ac..2b29240d 100644
--- a/mkfs/proto.c
+++ b/mkfs/proto.c
@@ -1425,7 +1425,7 @@ handle_hardlink(
 	if (dst_ino == 0)
 		return false;
 
-	error = libxfs_iget(mp, NULL, dst_ino, 0, &ip);
+	error = -libxfs_iget(mp, NULL, dst_ino, 0, &ip);
 	if (error)
 		fail(_("failed to get inode"), error);