From: Gerald (Jerry) Carter <jerry@samba.org>
Date: Fri, 3 Oct 2008 15:51:21 +0000 (-0500)
Subject: libaddns: Use the same prerequisite for DDNS update as Windows XP.
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=adde53eddb85e9af391c3f77425a3376c5c60dbf;p=thirdparty%2Fsamba.git

libaddns: Use the same prerequisite for DDNS update as Windows XP.

   Hostname, TYPE: CNAME, CLASS: NONE

This has to have been broken for ages.  I cannot see
how it would have worked in any environment.
(cherry picked from commit 6b6402bce318a48b0890ed6fc23ed5b30440927b)
---

diff --git a/source/libaddns/dnsrecord.c b/source/libaddns/dnsrecord.c
index 500cbd6681a..559c2644d44 100644
--- a/source/libaddns/dnsrecord.c
+++ b/source/libaddns/dnsrecord.c
@@ -378,10 +378,10 @@ DNS_ERROR dns_create_update_request(TALLOC_CTX *mem_ctx,
 	if (!ERR_DNS_IS_OK(err)) return err;
 
 	/*
-	 * The zone must be used at all
+	 * Use the same prereq as WinXP -- No CNAME records for this host.
 	 */
 
-	err = dns_create_rrec(req, domainname, QTYPE_ANY, DNS_CLASS_ANY,
+	err = dns_create_rrec(req, hostname, QTYPE_CNAME, DNS_CLASS_NONE,
 			      0, 0, NULL, &rec);
 	if (!ERR_DNS_IS_OK(err)) goto error;