From: Daniel Pinto <danielpinto52@gmail.com>
Date: Tue, 12 Sep 2017 22:07:06 +0000 (+0100)
Subject: Fix memory leak when options_init_from_string returns error #22605
X-Git-Tag: tor-0.3.3.1-alpha~280^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=ade9baaf9b40c419f3ddefe6c8ee8f2c5ec8edce;p=thirdparty%2Ftor.git

Fix memory leak when options_init_from_string returns error #22605
---

diff --git a/src/or/config.c b/src/or/config.c
index 56d2e0621a..753547767f 100644
--- a/src/or/config.c
+++ b/src/or/config.c
@@ -5210,6 +5210,12 @@ options_init_from_string(const char *cf_defaults, const char *cf,
   return SETOPT_OK;
 
  err:
+  if (opened_files) {
+    SMARTLIST_FOREACH(opened_files, char *, f, tor_free(f));
+    smartlist_free(opened_files);
+  }
+  // may have been set to opened_files, avoid double free
+  newoptions->FilesOpenedByIncludes = NULL;
   or_options_free(newoptions);
   or_options_free(newdefaultoptions);
   if (*msg) {