From: Joe Orton <jorton@apache.org>
Date: Thu, 30 Oct 2003 12:07:06 +0000 (+0000)
Subject: Fix missing human-readable error information in SSL log messages:
X-Git-Tag: pre_ajp_proxy~1095
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=ae0cef9c800a1ec8d30ee1e97d5a8c825e402fd6;p=thirdparty%2Fapache%2Fhttpd.git

Fix missing human-readable error information in SSL log messages:

* mod_ssl.c (ssl_cleanup_pre_config): Don't free the error strings,
since they can't be loaded again once.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@101624 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/modules/ssl/mod_ssl.c b/modules/ssl/mod_ssl.c
index c404c4908ef..cdff9f61038 100644
--- a/modules/ssl/mod_ssl.c
+++ b/modules/ssl/mod_ssl.c
@@ -255,7 +255,11 @@ static apr_status_t ssl_cleanup_pre_config(void *data)
 #endif
 #endif
     ERR_remove_state(0);
-    ERR_free_strings();
+
+    /* Don't call ERR_free_strings here; ERR_load_*_strings only
+     * actually load the error strings once per process due to static
+     * variable abuse in OpenSSL. */
+
     /* 
      * TODO: determine somewhere we can safely shove out diagnostics 
      *       (when enabled) at this late stage in the game: