From: Andreas Schneider Date: Fri, 5 Jul 2024 11:58:53 +0000 (+0200) Subject: s4:torture: Initialize union smb_open X-Git-Tag: tdb-1.4.11~134 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=ae47ec172fba0a508eb084505db52640685c161a;p=thirdparty%2Fsamba.git s4:torture: Initialize union smb_open "Error: UNINIT (CWE-457): samba-4.20.0rc2/source4/torture/raw/open.c:1136: var_decl: Declaring variable ""io1"" without initializer. samba-4.20.0rc2/source4/torture/raw/open.c:1198: uninit_use_in_call: Using uninitialized value ""io1.ntcreatex.out.file.fnum"" when calling ""smbcli_close"". 1196| done: 1197| smbcli_close(cli->tree, io.ntcreatex.out.file.fnum); 1198|-> smbcli_close(cli->tree, io1.ntcreatex.out.file.fnum); 1199| smbcli_deltree(cli->tree, BASEDIR); 1200| return ret;" Signed-off-by: Andreas Schneider Reviewed-by: Guenther Deschner --- diff --git a/source4/torture/raw/open.c b/source4/torture/raw/open.c index 446a284d510..f4eeb4e8c6e 100644 --- a/source4/torture/raw/open.c +++ b/source4/torture/raw/open.c @@ -1133,7 +1133,7 @@ done: */ static bool test_ntcreatex_brlocked(struct torture_context *tctx, struct smbcli_state *cli) { - union smb_open io, io1; + union smb_open io = {}, io1 = {}; union smb_lock io2; struct smb_lock_entry lock[1]; const char *fname = BASEDIR "\\torture_ntcreatex.txt";