From: Guido van Rossum <guido@python.org>
Date: Wed, 19 Aug 1992 16:49:58 +0000 (+0000)
Subject: splitfields(s, '') is illegal
X-Git-Tag: v0.9.8~203
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=ae507a42a0425f2397a5f7b3163dc0c1d6d0aaef;p=thirdparty%2FPython%2Fcpython.git

splitfields(s, '') is illegal
---

diff --git a/Lib/string.py b/Lib/string.py
index 94e91570c5c7..f358ac477883 100644
--- a/Lib/string.py
+++ b/Lib/string.py
@@ -63,10 +63,14 @@ def split(s):
 
 # Split a list into fields separated by a given string
 # NB: splitfields(s, ' ') is NOT the same as split(s)!
+# splitfields(s, '') is illegal
+splitfields_error = 'string.splitfields called with empty separator'
 def splitfields(s, sep):
 	res = []
-	ns = len(s)
 	nsep = len(sep)
+	if nsep == 0:
+		raise splitfields_error
+	ns = len(s)
 	i = j = 0
 	while j+nsep <= ns:
 		if s[j:j+nsep] == sep:
diff --git a/Lib/stringold.py b/Lib/stringold.py
index 94e91570c5c7..f358ac477883 100644
--- a/Lib/stringold.py
+++ b/Lib/stringold.py
@@ -63,10 +63,14 @@ def split(s):
 
 # Split a list into fields separated by a given string
 # NB: splitfields(s, ' ') is NOT the same as split(s)!
+# splitfields(s, '') is illegal
+splitfields_error = 'string.splitfields called with empty separator'
 def splitfields(s, sep):
 	res = []
-	ns = len(s)
 	nsep = len(sep)
+	if nsep == 0:
+		raise splitfields_error
+	ns = len(s)
 	i = j = 0
 	while j+nsep <= ns:
 		if s[j:j+nsep] == sep: