From: Brett Cannon <brett@python.org>
Date: Fri, 12 Jul 2013 15:30:32 +0000 (-0400)
Subject: Issue #17845: Clarify the message setup.py prints upon successfully
X-Git-Tag: v3.4.0a1~231
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=ae95b4f7a5344de372885fb25d8fadbb14c8fea4;p=thirdparty%2FPython%2Fcpython.git

Issue #17845: Clarify the message setup.py prints upon successfully
building Python but having some optional module which didn't build.

Patch by Yogesh Chaudhari.
---

diff --git a/Misc/NEWS b/Misc/NEWS
index b65498abe463..bcdfbf3b6d5a 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -631,6 +631,8 @@ IDLE
 Build
 -----
 
+- Issue #17845: Clarified the message printed when some module are not built.
+
 - Issue #18256: Compilation fix for recent AIX releases.  Patch by
   David Edelsohn.
 
diff --git a/setup.py b/setup.py
index 798220b48ecb..b2417c790e21 100644
--- a/setup.py
+++ b/setup.py
@@ -259,8 +259,9 @@ class PyBuildExt(build_ext):
 
         if missing:
             print()
-            print("Python build finished, but the necessary bits to build "
-                   "these modules were not found:")
+            print("Python build finished successfully!")
+            print("The necessary bits to build these optional modules were not "
+                  "found:")
             print_three_column(missing)
             print("To find the necessary bits, look in setup.py in"
                   " detect_modules() for the module's name.")