From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Mon, 10 Dec 2018 16:16:55 +0000 (+0100)
Subject: dnsdist: Update DNSCrypt's regression tests for Python 3
X-Git-Tag: rec-4.2.0-alpha1~68^2~1
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=ae99f8530db7b590ef65943b91ae1560dd7b49f6;p=thirdparty%2Fpdns.git

dnsdist: Update DNSCrypt's regression tests for Python 3
---

diff --git a/regression-tests.dnsdist/dnscrypt.py b/regression-tests.dnsdist/dnscrypt.py
index bc1a296b42..7fed0c4050 100644
--- a/regression-tests.dnsdist/dnscrypt.py
+++ b/regression-tests.dnsdist/dnscrypt.py
@@ -7,12 +7,12 @@ import dns.message
 import libnacl
 import libnacl.utils
 import binascii
-
+from builtins import bytes
 
 class DNSCryptResolverCertificate(object):
-    DNSCRYPT_CERT_MAGIC = '\x44\x4e\x53\x43'
-    DNSCRYPT_ES_VERSION = '\x00\x01'
-    DNSCRYPT_PROTOCOL_MIN_VERSION = '\x00\x00'
+    DNSCRYPT_CERT_MAGIC = b'\x44\x4e\x53\x43'
+    DNSCRYPT_ES_VERSION = b'\x00\x01'
+    DNSCRYPT_PROTOCOL_MIN_VERSION = b'\x00\x00'
 
     def __init__(self, serial, validFrom, validUntil, publicKey, clientMagic):
         self.serial = serial
@@ -51,7 +51,7 @@ class DNSCryptClient(object):
     DNSCRYPT_MAC_SIZE = 16
     DNSCRYPT_PADDED_BLOCK_SIZE = 64
     DNSCRYPT_MIN_UDP_LENGTH = 256
-    DNSCRYPT_RESOLVER_MAGIC = '\x72\x36\x66\x6e\x76\x57\x6a\x38'
+    DNSCRYPT_RESOLVER_MAGIC = b'\x72\x36\x66\x6e\x76\x57\x6a\x38'
 
     @staticmethod
     def _addrToSocketType(addr):
@@ -165,7 +165,7 @@ class DNSCryptClient(object):
     @staticmethod
     def _generateNonce():
         nonce = libnacl.utils.rand_nonce()
-        return nonce[:(DNSCryptClient.DNSCRYPT_NONCE_SIZE / 2)]
+        return nonce[:int(DNSCryptClient.DNSCRYPT_NONCE_SIZE / 2)]
 
     def _encryptQuery(self, queryContent, resolverCert, nonce, tcp=False):
         header = resolverCert.clientMagic + self._publicKey + nonce
@@ -176,14 +176,14 @@ class DNSCryptClient(object):
             paddingSize += self.DNSCRYPT_MIN_UDP_LENGTH - requiredSize
             requiredSize = self.DNSCRYPT_MIN_UDP_LENGTH
 
-        padding = '\x80'
+        padding = b'\x80'
         idx = 0
         while idx < (paddingSize - 1):
-            padding = padding + '\x00'
+            padding = padding + b'\x00'
             idx += 1
 
         data = queryContent + padding
-        nonce = nonce + ('\x00'*(self.DNSCRYPT_NONCE_SIZE / 2))
+        nonce = nonce + (b'\x00'*int(self.DNSCRYPT_NONCE_SIZE / 2))
         box = libnacl.crypto_box(data, nonce, resolverCert.publicKey, self._privateKey)
         return header + box
 
@@ -193,21 +193,22 @@ class DNSCryptClient(object):
             raise Exception("Invalid encrypted response: bad resolver magic")
 
         nonce = encryptedResponse[8:32]
-        if nonce[0:self.DNSCRYPT_NONCE_SIZE / 2] != clientNonce:
+        if nonce[0:int(self.DNSCRYPT_NONCE_SIZE / 2)] != clientNonce:
             raise Exception("Invalid encrypted response: bad nonce")
 
         cleartext = libnacl.crypto_box_open(encryptedResponse[32:], nonce, resolverCert.publicKey, self._privateKey)
-        idx = len(cleartext) - 1
+        cleartextBytes = bytes(cleartext)
+        idx = len(cleartextBytes) - 1
         while idx > 0:
-            if cleartext[idx] != '\x00':
+            if cleartextBytes[idx] != 0:
                 break
             idx -= 1
 
-        if idx == 0 or cleartext[idx] != '\x80':
+        if idx == 0 or cleartextBytes[idx] != 128:
             raise Exception("Invalid encrypted response: invalid padding")
 
         idx -= 1
-        paddingLen = len(cleartext) - idx
+        paddingLen = len(cleartextBytes) - idx
 
         return cleartext[:idx+1]