From: Christian Dywan <christian.dywan@lanedo.com>
Date: Tue, 20 Jul 2010 09:53:15 +0000 (+0200)
Subject: Take care to free windows_sid in cache_peer_loginfo_string
X-Git-Tag: dbus-1.4.1~44
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=aea8da08d12e2d4b224a8d3cdc8b0dee4b856216;p=thirdparty%2Fdbus.git

Take care to free windows_sid in cache_peer_loginfo_string
---

diff --git a/bus/connection.c b/bus/connection.c
index 718a4f622..8e7d222a7 100644
--- a/bus/connection.c
+++ b/bus/connection.c
@@ -586,9 +586,12 @@ cache_peer_loginfo_string (BusConnectionData *d,
 
   if (dbus_connection_get_windows_user (connection, &windows_sid))
     {
-      if (!_dbus_string_append_printf (&loginfo_buf, "sid=\"%s\" ", windows_sid))
-        goto oom;
+      dbus_bool_t did_append;
+      did_append = _dbus_string_append_printf (&loginfo_buf,
+                                               "sid=\"%s\" ", windows_sid);
       dbus_free (windows_sid);
+      if (!did_append)
+        goto oom;
     }
 
   if (!_dbus_string_steal_data (&loginfo_buf, &(d->cached_loginfo_string)))