From: Richard Sharpe Date: Tue, 24 May 2016 00:37:13 +0000 (-0700) Subject: source4/scripting: add an option to samba_dnsupdate to add ns records. X-Git-Tag: tdb-1.3.10~755 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=af08cb2eee9dc9fabad6ca62ca11728209297222;p=thirdparty%2Fsamba.git source4/scripting: add an option to samba_dnsupdate to add ns records. Add a --add-ns option to samba_dnsupdate and use that, but only when --use-file has been specified, to add an NS record to the file produced. This allows us to make progress in the self tests and is an interim fix. Signed-off-by: Richard Sharpe Reviewed-by: Rowland Penny Autobuild-User(master): Jeremy Allison Autobuild-Date(master): Tue Jun 21 00:51:02 CEST 2016 on sn-devel-144 --- diff --git a/source4/scripting/bin/samba_dnsupdate b/source4/scripting/bin/samba_dnsupdate index 16265f639fd..3880ddad7f9 100755 --- a/source4/scripting/bin/samba_dnsupdate +++ b/source4/scripting/bin/samba_dnsupdate @@ -69,6 +69,7 @@ parser.add_option("--all-interfaces", action="store_true") parser.add_option("--current-ip", action="append", help="IP address to update DNS to match (helpful if behind NAT, valid multiple times, defaults to values from interfaces=)") parser.add_option("--rpc-server-ip", type="string", help="IP address of server to use with samba-tool (defaults to first --current-ip)") parser.add_option("--use-file", type="string", help="Use a file, rather than real DNS calls") +parser.add_option("--add-ns", action="store_true", help="Add an NS record to the DNS file for self-tests. Can only be used with --use-file") parser.add_option("--update-list", type="string", help="Add DNS names from the given file") parser.add_option("--update-cache", type="string", help="Cache database of already registered records") parser.add_option("--fail-immediately", action='store_true', help="Exit on first failure") @@ -681,6 +682,15 @@ dup_set = set() cache_set = set() rebuild_cache = False + +# Add an NS line if asked to ... +if opts.add_ns: + if opts.use_file is None: + print "Option --add-ns can only be used with --use-file" + sys.exit(1) + else: + dns_list.append(parse_dns_line("NS ${DNSDOMAIN} ${HOSTNAME}", sub_vars)) + try: cfile = open(dns_update_cache, 'r+') except IOError: