From: Joseph Sutton <josephsutton@catalyst.net.nz>
Date: Wed, 27 Sep 2023 00:59:32 +0000 (+1300)
Subject: s4:kdc: Check that principal being copied is not NULL
X-Git-Tag: tevent-0.16.0~288
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=af22a6552dfb1058ce34f3056bf90131f5ff8fe5;p=thirdparty%2Fsamba.git

s4:kdc: Check that principal being copied is not NULL

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/source4/kdc/sdb_to_hdb.c b/source4/kdc/sdb_to_hdb.c
index 6609bc6d803..a42d460a768 100644
--- a/source4/kdc/sdb_to_hdb.c
+++ b/source4/kdc/sdb_to_hdb.c
@@ -210,11 +210,13 @@ int sdb_entry_to_hdb_entry(krb5_context context,
 
 	*h = (hdb_entry) {};
 
-	rc = krb5_copy_principal(context,
-				 s->principal,
-				 &h->principal);
-	if (rc != 0) {
-		return rc;
+	if (s->principal != NULL) {
+		rc = krb5_copy_principal(context,
+					 s->principal,
+					 &h->principal);
+		if (rc != 0) {
+			return rc;
+		}
 	}
 
 	h->kvno = s->kvno;